fix(db): don't depend on the Postgres session timezone - #1560
Open
Akshats-git wants to merge 1 commit into
Open
Conversation
…ones in queries and tests Signed-off-by: Akshat <akshatgupta099@gmail.com>
Akshats-git
force-pushed
the
fix/postgres-session-timezone
branch
from
August 16, 2026 12:51
4d6b184 to
70aa9c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1541
The instance and update stats queries compared timestamptz columns against
now() at time zone 'utc'. That expression returns a plain timestamp with no zone, so Postgres converts it back using the session timezone. Every time window was shifted by the session offset.If the session runs in UTC nothing is wrong. Anything else and the instance counts on the dashboard are off, and the rollout policy sees granted updates as older or younger than they are. West of UTC they time out early, which disables updates for the whole group under safe mode. East of UTC they stay in progress past the timeout and new instances get held back.
Changes:
now() at time zone 'utc'with plainnow()in the five stats queries and in GetGroupUpdatesStats. The timeline queries in the same package already used plainnow(), so this also makes them agree.Tested against postgres:16.3-alpine started with
-c timezone=America/New_York. With the query fix reverted the new tests fail in both directions, so they cover the actual regression. Full backend suite passes against a non-UTC server and a UTC one.