updater: map ProgressInstallationFinished to EventTypeInstallComplete - #1462
Open
princexpoddar wants to merge 2 commits into
Open
updater: map ProgressInstallationFinished to EventTypeInstallComplete#1462princexpoddar wants to merge 2 commits into
princexpoddar wants to merge 2 commits into
Conversation
Fix a copy-paste error in progressToEventRequest where ProgressInstallationFinished was mapped to omaha.EventTypeInstallStarted instead of omaha.EventTypeInstallComplete. Add TestProgressToEventRequest to verify that all progress enum values map to their expected Omaha event types and results. Fixes flatcar#1460 Signed-off-by: Prabal Poddar <prabalpoddar73@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1460
Description
progressToEventRequestinupdater/updater.gomappedProgressInstallationFinishedtoomaha.EventTypeInstallStartedinstead ofomaha.EventTypeInstallComplete, causing installation completion to be reported using the same Omaha event type as installation start.Changes
ProgressInstallationFinishedto returnomaha.EventTypeInstallComplete.TestProgressToEventRequestto verify that eachprogressvalue maps to the expected Omaha event type and result.nil.Verification
Ran the updater unit tests: