feat: add CreateMCPServer + harden redactor for user-keyed maps#12
Open
ysyneu wants to merge 1 commit into
Open
feat: add CreateMCPServer + harden redactor for user-keyed maps#12ysyneu wants to merge 1 commit into
ysyneu wants to merge 1 commit into
Conversation
POST /safari/mcp/server/create wrapper, used by the AI SRE /init slash command to register user-provided MCP servers. Also extends the body redactor: env and headers hold user-supplied credentials with arbitrary key names (e.g. OPENAI_API_KEY) that won't match the standard sensitive-keys allowlist. When the redactor descends into a map keyed under env or headers, every leaf is replaced with [REDACTED] regardless of inner key name. TeamID has no omitempty because 0 is a meaningful sentinel for account scope (distinct from "field omitted").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /safari/mcp/server/createwrapper for the AI-SRE/initslash command to register user-provided MCP servers.envorheadersmaps, every leaf value is replaced with[REDACTED], so user-keyed credentials (e.g.OPENAI_API_KEY) are scrubbed even when their key names don't match the standard sensitive-key allowlist.TeamIDkeeps0as a meaningful sentinel for account-scope (distinct from "field omitted"), so noomitempty.Why now
Unblocks flashduty-cli PR #11 (
feat: mcp create + alert events + change list polish), which depends on this SDK method.Test plan
go mod tidyagainst this SHA resolves without needing the local replace directive