Update dependency msgpack to v1.2.1#47
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR updates the pinned ChangesDependency Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
39d088c to
42245ca
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@api/tacticalrmm/requirements.txt`:
- Line 18: The PR description and the requirements.txt change disagree:
requirements.txt now pins msgpack==1.2.0 but the PR text says v1.1.2; update the
PR to accurately reflect the package change or adjust the requirements back to
1.1.2. Locate the dependency line "msgpack==1.2.0" in requirements.txt and
either (a) update the PR title/description and include relevant v1.2.0 release
notes or breaking changes, or (b) change the pinned version to "msgpack==1.1.2"
if that was intended, then run your dependency/build checks and update the PR
body to match.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f78d06b3-d9d9-4664-87d8-8bb5e978f801
📒 Files selected for processing (1)
api/tacticalrmm/requirements.txt
| kombu==5.4.2 | ||
| meshctrl==0.1.15 | ||
| msgpack==1.1.0 | ||
| msgpack==1.2.0 |
There was a problem hiding this comment.
Clarify version discrepancy between PR description and actual change.
The PR description mentions updating to v1.1.2 (with only build/wheel updates), but the actual change updates to v1.2.0. This inconsistency should be clarified—if v1.2.0 is intended, the PR description should be updated to reflect the correct version and include any relevant v1.2.0 release notes or breaking changes.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@api/tacticalrmm/requirements.txt` at line 18, The PR description and the
requirements.txt change disagree: requirements.txt now pins msgpack==1.2.0 but
the PR text says v1.1.2; update the PR to accurately reflect the package change
or adjust the requirements back to 1.1.2. Locate the dependency line
"msgpack==1.2.0" in requirements.txt and either (a) update the PR
title/description and include relevant v1.2.0 release notes or breaking changes,
or (b) change the pinned version to "msgpack==1.1.2" if that was intended, then
run your dependency/build checks and update the PR body to match.
42245ca to
68e711c
Compare
This PR contains the following updates:
==1.1.0→==1.2.1Release Notes
msgpack/msgpack-python (msgpack)
v1.2.1Compare Source
Release Date: 2026-06-19
Fix a segfault when calling
Unpacker.unpack()orUnpacker.skip()after an unpacking failure.But note that reusing the same
Unpackerinstance after an unpacking failure is not supported.Please create a new
Unpackerinstance instead. GHSA-6v7p-g79w-8964v1.2.0Compare Source
Release Date: 2026-06-11
strict_map_keyoption didn't work forobject_pairs_hook. #673Packer.pack_ext_type()ignoredautoresetoption. #663Timestamp.from_datetime()returning wrong value for pre-epoch datetimes. #662unpackb()andUnpacker.unpack()for non-contiguous input. #677Unpacker.__init__()several times. #687v1.1.2Compare Source
Release Date: 2025-10-08
This release does not change source code. It updates only building
wheels:
v1.1.1Compare Source
Release Date: 2025-06-13
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.