Skip to content

Skip binary permission check for openframe mode #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirill-567 merged 5 commits into from
Oct 2, 2025
+4 −1
Merged

Skip binary permission check for openframe mode #6

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c02946
Trigger build
Oct 2, 2025
f8ae357
Merge branch 'master' into feature/permissions
kirill-567 Oct 2, 2025
e63f858
Fixes
Oct 2, 2025
febbb1e
Fixes
Oct 2, 2025
7640dd5
Roll
Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion osquery/filesystem/filesystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ FLAG(uint64, read_max, 50 * 1024 * 1024, "Maximum file read size");
/// See reference #1382 for reasons why someone would allow unsafe.
HIDDEN_FLAG(bool, allow_unsafe, false, "Allow unsafe executable permissions");

DECLARE_bool(openframe_mode);

namespace {
const size_t kMaxRecursiveGlobs = 64;

Expand Down Expand Up @@ -612,7 +614,8 @@ bool safePermissions(const fs::path& dir,
result = fd.isExecutable();

// Otherwise, require matching or root file ownership.
if (executable && (result.getCode() > 0 || !fd.hasSafePermissions().ok())) {
// TODO: Remove permissions check skip after openframe agent will support setting safe permissions.
if (executable && (result.getCode() > 0 || (!FLAGS_openframe_mode && !fd.hasSafePermissions().ok()))) {
// Require executable, implies by the owner.
return false;
}
Expand Down
Loading