restrict agent tool proxy requests to own device only#890
Open
MorganaFuture wants to merge 2 commits into
Open
restrict agent tool proxy requests to own device only#890MorganaFuture wants to merge 2 commits into
MorganaFuture wants to merge 2 commits into
Conversation
agents with a valid JWT could request data for any device by specifying an arbitrary agentId in the path. added ownership check via tool_connections before proxying — returns 403 if the jwt machine_id doesn't match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Agents with a valid JWT could proxy requests to any device by specifying an arbitrary agentId in the path. Fixed by validating JWT machine_id against tool_connections before forwarding returns 403 on mismatch.
Improvements