feat(seo): seo_description length SSOT + editor counter/maxLength#1441
Conversation
… [preview:none] Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe SEO editor preview now uses a shared 160-character description limit, enforces it on the description textarea, and displays live length feedback with an over-limit warning. The SEO title warning wording is also updated. ChangesSEO description length limit
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@openframe-frontend-core/src/components/features/seo-editor-preview.tsx`:
- Around line 215-219: Update the SEO description Textarea in the preview
component to pass invalid={seoDescriptionTooLong}, matching the existing
seoTitleTooLong handling on the SEO title Input and preserving all other
Textarea props.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 6ee4aab6-6ea0-4d70-9e64-ccf7d334bac3
📒 Files selected for processing (3)
openframe-frontend-core/src/components/features/seo-editor-preview.tsxopenframe-frontend-core/src/utils/index.tsopenframe-frontend-core/src/utils/seo-description.ts
…y [preview:none] Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
What
SEO length SSOT + editor UX for the shared SEO editor, consumed by the hub's AI-SEO overflow fixes (paired PR: flamingo-stack/multi-platform-hub).
SEO_DESCRIPTION_MAX_LENGTH = 160now lives in the lib (src/utils/seo-description.ts, exported fromsrc/utils/index.ts), mirroring the existingSEO_TITLE_MAX_LENGTH. The hub re-exports it so there is one source of truth for thevarchar(160)budget.SEOEditorPreview: theseo_descriptiontextarea now has a liveNNN/160counter, a "too long" hint, andmaxLength={160}— the same treatmentseo_titlealready had. Reuses existing ODS tokens (text-ods-error,text-ods-text-secondary). The pre-existing em-dash in theseo_titlehint was replaced with a colon (repo copy rule).Why
The hub was overflowing
varchar(160)/varchar(60)SEO columns on save. The hub fix rewrites over-budget AI text to fit and reports precise errors; this lib change gives the shared editor the length SSOT + a visible counter so a human editing the field sees the limit.Rollout
Paired change: merge + release, then the hub bumps its
@flamingo-stack/openframe-frontend-corepin to the new version.🤖 Generated with Claude Code
Summary by CodeRabbit