Skip to content

Feature/improve logging #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kirill-567 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature/improve logging #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7f2178
Smart logging
Nov 4, 2025
b1f57cd
Draft
Nov 4, 2025
3c4a834
Draft
Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ permissions:

on:
push:
branches: [master]
branches: [master,feature/improve-logging]
paths-ignore:
- "**/*.md"
workflow_dispatch:
Expand Down
21 changes: 16 additions & 5 deletions meshcore/agentcore.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ limitations under the License.
#endif

#include "agentcore.h"
#include "openframe_file_logger.h"
#include "signcheck.h"
#include "meshdefines.h"
#include "meshinfo.h"
Expand Down Expand Up @@ -4988,11 +4989,21 @@ int MeshAgent_AgentMode(MeshAgentHostContainer *agentHost, int paramLen, char **
{
agentHost->capabilities |= MeshCommand_AuthInfo_CapabilitiesMask_RECOVERY; parseCommands = 0;
}
if (strcmp(param[ri], "--openframe-mode") == 0)
{
agentHost->openFrameMode = true; parseCommands = 0;
printf("OpenFrame Mode: %d\n", agentHost->openFrameMode);
}
if (strcmp(param[ri], "--openframe-mode") == 0)
{
agentHost->openFrameMode = true; parseCommands = 0;
printf("OpenFrame Mode: %d\n", agentHost->openFrameMode);

// Use fixed log directory for OpenFrame
#ifdef WIN32
const char* logDir = "C:\\ProgramData\\OpenFrame\\meshcentral-agent";
#else
const char* logDir = "/var/log/openframe/meshcentral-agent";
#endif

printf("Log directory: %s\n", logDir);
enable_file_logging(logDir, "meshagent");
}
if (strcmp(param[ri], "--openframe-secret") == 0 && ((ri + 1) < paramLen))
{
agentHost->openFrameSecret = param[ri + 1]; parseCommands = 0;
Expand Down
Loading
Loading