Skip to content

feat(drill): shared Z bar in fiducial centering (safe-descent mode)#694

Merged
fixcik merged 1 commit into
masterfrom
feat/fiducial-zbar-new
Jun 16, 2026
Merged

feat(drill): shared Z bar in fiducial centering (safe-descent mode)#694
fixcik merged 1 commit into
masterfrom
feat/fiducial-zbar-new

Conversation

@fixcik

@fixcik fixcik commented Jun 16, 2026

Copy link
Copy Markdown
Owner

Фоллоу-ап к #662 (эпик #656). Z-управление в панели центровки теперь — наш стандартный бар DrillManualZBar (как везде), вместо самодельных Z−/Z+ кнопок.

Бар обобщён безопасным режимом (safeDescent), т.к. его обычные взаимодействия опасны для спуска без привязанного Z-нуля:

  • клик по треку ВНИЗ — игнорируется (isSafeDescentTarget), вверх — ок;
  • Z± — только клик-шаг (без continuous/hold);
  • инлайн-редактор ридаута отключён (нет прыжка Z в произвольную точку);
  • шаги заперты [0.05/0.1/0.5], спуск Z− на медленной подаче 60 мм/мин, подъём — обычной;
  • клэмп к машинному Z-envelope.
    Тул-ченджевый бар (без пропа safeDescent) — без изменений. Кнопка «безоп. Z» (rapid-ретракт) оставлена рядом.

Фрейм-фикс #692 в панели (навод jogTo(ideal), envelope вокруг ideal+WCO, баннер «выставьте рабочий ноль», гейт homed) — не затронут.

Плюс правка docs/PROJECT.md: формулировка центровки «машинные позиции/machine-координата» → work(G54) (убираю тот же неверный ярлык, что породил #688).

821 фронт-тест зелёные (+4 на isSafeDescentTarget), i18n паритет en/ru.

Refs #662

@fixcik fixcik enabled auto-merge (squash) June 16, 2026 00:13
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@fixcik, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 10 minutes and 31 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0379fbbd-0ce4-491e-bcc1-22a4efcbe7b9

📥 Commits

Reviewing files that changed from the base of the PR and between 5c6c804 and 6fc643b.

📒 Files selected for processing (7)
  • cuprum-ui/src/components/drill/DrillManualZBar.tsx
  • cuprum-ui/src/components/drill/FiducialPanel.tsx
  • cuprum-ui/src/lib/zbar.test.ts
  • cuprum-ui/src/lib/zbar.ts
  • cuprum-ui/src/locales/en/drill.json
  • cuprum-ui/src/locales/ru/drill.json
  • docs/PROJECT.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fixcik fixcik merged commit 34f3995 into master Jun 16, 2026
4 checks passed
@fixcik fixcik deleted the feat/fiducial-zbar-new branch June 16, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant