refactor: typed control message enums + AcceptErr reply#5
Open
GregoryLi360 wants to merge 10 commits into
Open
refactor: typed control message enums + AcceptErr reply#5GregoryLi360 wants to merge 10 commits into
GregoryLi360 wants to merge 10 commits into
Conversation
merge main into majdnasra2/comm-protocol
…ly enums via TryFrom
GregoryLi360
force-pushed
the
refactor/control-message-enums
branch
from
48aa336 to
464e93d
Compare
GregoryLi360
changed the title
GregoryLi360
requested review from
Akshay-Srivatsan and
ruiting-chen
and removed request for
Akshay-Srivatsan
ruiting-chen
force-pushed
the
majdnasra2/comm-protocol
branch
from
d762d8e to
8e4e10f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes review comments on
control/src/protocol.rs:116,:144, andmonitor/src/lib.rs:206.Refactor (
464e93d):ControlRequest/ControlReplyenums in newcontrol/src/message.rs.TryFrom<&ControlFrame>, encoding viato_frame().decodemethods and theListenerReady/AcceptListenerId/ErrPayloadcarrier structs; variants hold the field directly.AcceptErr (
f2bee49):MessageType::AcceptErr = 9andControlReply::AcceptErr { request_id, code }.AcceptErrinstead of returningMonitorError::UnknownListener(code9/EBADF) and instead of silently swallowing kernelacceptfailures.ArcaError::AcceptFailed { code }.29 tests pass (21 control, 6 monitor, 2 e2e). Clippy and fmt clean.