Better "manual activity" support by preprocessing TCXs#7
Open
Ondkloss wants to merge 1 commit into
Open
Conversation
…at is, workouts that only had a single trackpoint, og none at all. These now get two points, which means they will get included and show duration and distance. Note that this means that your TCX file WILL BE OVERWRITTEN with the altered data. Keep a backup! Additional changes include: * Added more sports to the SPORTMAP * Copied over "notes" from Endomondo to "description" in Strava * Changed the activity name to include the original Endomondo name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm submitting this pull request not so much to get it accepted, but more to make viewers aware of a potential fix if they were heavy users of Endomondo manual activities. As a user of "manual activities" in Endomondo I found many of my activities to not be included by this project, because the TCX files had one or zero trackpoints and the upload ignores these, or loses duration and distance information.
This pull request (and the fork it comes from) solves this problem by overwriting the TCX with two trackpoints in these specific cases. These trackpoints causes the exercise to get both duration and distance if specified from the Endomondo source, by fetching it from the JSON.
Below are some other aspects of this pull request and fork to evaluate:
For any user of this, by all means, remember to: