This repository was archived by the owner on Jul 22, 2026. It is now read-only.
party: add support for sending pings with different types#2
Open
fisherrjd wants to merge 14 commits into
Open
Conversation
renamed TilePing to PartyPing as it is no longer limited to only tile pings and added a ping type and ping target type to PartyPing
fixes an issue where pinging the same target repeatedly will overlay multiple pings and cause a lot of visual clutter
indirectly also fixes an issue where ping duration varied based on how many fps the client was running at
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
renamed TilePing to PartyPing as it is no longer limited to only tile pings and added a ping type and ping target type to PartyPing