Implement an infrastructure for auto discovery of evaluators and validators.#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to automatically discover the partial evaluators and validators. The users, once they add implementations for
IEvaluator,IMemoryEvaluator, orIValidator, no longer need to add/register them manually. They will be discovered automatically and added to the pipeline.I wanted to expose this as an optional feature. I added targets as part of the NuGet package, and the feature can be enabled by setting the following property in your .csproj file
Additionally, a discovery attribute can be applied to each evaluator/validator individually. You can control the order and also have the ability to disable a specific evaluator/validator from discovery. The default order is
int.MaxValueand is enabled by default. If no attribute is applied, the default values will be assumed.