fix(ra.viewer): escape brand in public render API#103
Open
erayack wants to merge 1 commit into
Open
Conversation
Add a regression test for render_page shell chrome escaping so custom brands cannot inject markup into the generated viewer.
erayack
force-pushed
the
fix/escape-viewer-brand
branch
from
6b3bf59 to
4af95f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an HTML injection issue in the public
ra.viewerrendering API.The
brandargument passed torender_page(..., brand=...)was inserted directly into the generated HTML shell, including the document<title>and page header. A crafted value could break out of those locations and inject markup or script tags.This PR escapes the generated shell title and brand label before substitution, and adds a regression test to ensure malicious brand values remain rendered as text.
Validation
uv run pytestuv run pytest tests/test_ra_viewer.py tests/test_viewer.pyuv run ruff check src/ra/viewer/html.py tests/test_ra_viewer.pyuv run ruff format --check src/ra/viewer/html.py tests/test_ra_viewer.py