fix(viewer): drop meaningless '0' label on compare level bars#17
Merged
Conversation
The compare page reused svg.hbar — built for integer *count* breakdowns (it prints int(value) at the bar's end) — to draw a continuous score-gap magnitude bar. int(0.07) rendered a stray '0' next to every bar, while the exact gap was already in the adjacent 'vs best' column. Add hbar(show_label=...): default keeps the count label (AI-models breakdown); compare passes show_label=False so the magnitude bar carries no orphan label and uses the reclaimed width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted while reviewing the viewer. The
comparepage reusedsvg.hbar— which was built for integer count breakdowns ("AI models used") and printsint(value)at the bar's end — to draw a continuous score-gap magnitude bar.int(0.07)rendered a stray "0" next to every level bar, even though the exact gap is already shown in the adjacentvs bestcolumn.Fix:
hbargainsshow_label(defaultTrue, unchanged for the models breakdown).comparepassesshow_label=False, so the magnitude bar carries no orphan label and reclaims the label's width.Test:
test_hbar_label_toggleasserts count bars keep<text>and magnitude bars omit it. Verified on the live viewer — zero orphan0labels on/compare.🤖 Generated with Claude Code