Skip to content

update dnsmasq, fix CVEs#1901

Merged
jasonlyc merged 1 commit into
firewalla:masterfrom
caixingcheng:my_dev
Jun 18, 2026
Merged

update dnsmasq, fix CVEs#1901
jasonlyc merged 1 commit into
firewalla:masterfrom
caixingcheng:my_dev

Conversation

@caixingcheng

Copy link
Copy Markdown
Contributor

@j-sallyjin

This comment has been minimized.

@caixingcheng caixingcheng marked this pull request as draft June 5, 2026 09:18
@caixingcheng caixingcheng marked this pull request as ready for review June 11, 2026 01:34
@j-sallyjin

Copy link
Copy Markdown

PR Review Summary

✅ What looks good

  • Updates dnsmasq binaries for all affected platform paths in the PR scope:
    • platform/gold/bin/dnsmasq
    • platform/gold/bin/u22/dnsmasq
    • platform/pse/bin/dnsmasq
    • platform/purple/bin/dnsmasq
  • The replacement binaries preserve the expected architecture families:
    • Gold / Gold U22: x86-64 ELF
    • PSE / Purple: aarch64 ELF
  • No linked GitHub issue found.

⚠️ Issues found

  • Medium: CVE fix cannot be independently verified from the PR.
    The PR is binary-only and lists CVE-2026-4892, CVE-2026-4893, CVE-2026-5172, and CVE-2026-2291, but it does not include the upstream dnsmasq version, source commit, package version, downstream patch reference, build command, or checksum/provenance table. For a security update, reviewers need enough metadata to confirm these artifacts actually contain the intended fixes.

  • Medium: Binary version metadata is not useful for validation.
    String inspection still shows dnsmasq-UNKNOWN / generic Dnsmasq version %s metadata, so the binaries themselves do not clearly expose the patched dnsmasq version.

💡 Suggestions

  • Add a PR body section with:
    • upstream dnsmasq version or exact patch commits
    • build environment and build command
    • per-platform dnsmasq --version output
    • SHA256 checksums for all four new binaries
    • smoke test results for startup, DNS forwarding, DHCPv4, and DHCPv6
  • If these binaries come from distro packages, document the exact package versions used for each platform, especially the U22 binary.

Verdict

REQUEST_CHANGES


Repo: firewalla/firerouter
PR: #1901
Head SHA: fb9b4d7ac4a10c1f47b25aabd4c09c3551e032e2
Checked at: 2026-06-11 09:39:06 CST

@jasonlyc jasonlyc merged commit 3044c3b into firewalla:master Jun 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants