Skip to content

Refactor Suggestions#237

Merged
rjsheperd merged 4 commits into
rj-auto-migratefrom
kc-auto-migrate
Jun 4, 2026
Merged

Refactor Suggestions#237
rjsheperd merged 4 commits into
rj-auto-migratefrom
kc-auto-migrate

Conversation

@Kcheung42
Copy link
Copy Markdown
Collaborator

Purpose

  • Refactor schema migration helpers to accept a realized db instead of conn (more idiomatic), but still maintains backward comparability with (ds/unwrap-db db)
  • ensure each step run-multi-step! can have an updated db after a previous step is ran. This is achieved by ensuring each step is a function that accepts a db, as opposed to before which would also allow a vector of datoms. The vector of datoms would have been built on a stale db state at the beginning before the doseq on the steps.

Related Issues

Submission Checklist

  • Included Jira issue in the PR title (e.g. BHP1-### <title>)
  • Code passes linter rules (clj-kondo --lint components/**/src bases/**/src projects/**/src)
  • Feature(s) work when compiled (clojure -M:compile-cljs)

Testing

Screenshots

@rjsheperd
Copy link
Copy Markdown
Contributor

Thanks for this contribution!

@rjsheperd rjsheperd merged commit 50cc932 into rj-auto-migrate Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants