dependency updates, mostly around typescript@6#547
Merged
Conversation
…sues - Enable esModuleInterop in tsconfig.base.json to support default imports from CommonJS modules. - Update namespace imports (import * as) to default imports for callable CJS dependencies (like supertest, connect, and chai-as-promised) in all test files. - Upgraded @types/node to @types/node@26 matching the Node.js runtime version, resolving the type declaration conflict for URLPattern and allowing us to compile without skipLibCheck. - Configure rootDir: src in tsconfig.publish.json to satisfy TypeScript 6.0 output structure validation. - Add ignoreDeprecations: 6.0 to preserve legacy moduleResolution: Node behavior without requiring file extensions on relative imports. - Convert export structure in src/middleware/rewrites.ts to export = to align with TypeScript's CJS default import interop rules.
There was a problem hiding this comment.
Code Review
This pull request updates several development dependencies, including ESLint, Prettier, and TypeScript to version 6.0.3, and adjusts TypeScript configurations to support these updates (notably enabling esModuleInterop). It also refactors imports across test files to use default imports, simplifies the environment middleware logic, and cleans up variable declarations in src/server.js. There are no review comments, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after getting rid of a bunch of audit warnings, I've upgraded many eslint and typescript packages to bring them up to more recent versions