remove unused files in dart functions gitignore#10516
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the .gitignore template for Dart functions by removing several JavaScript-related ignore patterns. The reviewer recommends retaining the Firebase debug log patterns, as they are standard CLI artifacts, and suggests adding bin/server and functions.yaml to the ignore list to ensure build artifacts are not tracked in version control.
| *.js.symbols | ||
| firebase-debug.log | ||
| firebase-debug.*.log | ||
| *.local |
There was a problem hiding this comment.
The JavaScript-related patterns are unused in this context, but firebase-debug.log and its variants should be retained as they are standard artifacts produced by the Firebase CLI and should not be committed to version control. Additionally, it is recommended to ignore the compiled executable bin/server and the generated functions.yaml file, as these are build artifacts that should not be tracked in version control.
bin/server
functions.yaml
firebase-debug.log
firebase-debug.*.log
*.local
There was a problem hiding this comment.
This looks good. I think we should keep bin/server though.
There was a problem hiding this comment.
thanks for checking! added bin/server to the list
shettyvarun268
left a comment
There was a problem hiding this comment.
One very minor nit that we might want to mention in the description that we added bin/server in the file but apart from that LGTM!
Description
Removed unused files
.gitignoretemplate and addedbin/serverto the listFixes #10500. Imitates a similar
.gitignorefrom other templatesScenarios Tested
Ran

firebase init functionsNot sure if we might want to keep
build/. We do have build_runner in pubspec.yaml, and we do run it at some point so it might worth keeping?firebase-tools/src/deploy/functions/runtimes/dart/index.ts
Lines 163 to 170 in 7ce2bd5
Sample Commands