Conversation
|
I am still seeing the crash even with this change, in my reproduction here: samedson/issues#1 |
|
Here's the new stack I'm seeing, and the line in the changed code that is still leading to the crash.
|
samedson
approved these changes
Feb 4, 2021
samedson
left a comment
samedson
left a comment
Contributor
There was a problem hiding this comment.
Just a changelog and ship it!
Contributor
|
Oh looks like @chrisvasselli is crashing on the added callback too |
|
@samedson @elenadoty let me know if there's any more information about my system/setup you think might be useful. If you have any other fixes you'd like me to try, I'm happy to help. |
Contributor
Author
|
Hi @chrisvasselli , |
|
@elenadoty that one seems to be working! |
elenadoty
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#no-changelog