refactor: clean up legacy Swift 5.x version checks#16305
Conversation
Since the minimum supported Swift version across the SDK has been bumped to 5.9, `#if swift(>=5.x)` checks and their corresponding `#else` blocks evaluate to true by default and are no longer necessary. This commit removes these redundant directives to clean up the codebase.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request removes obsolete Swift version check compiler directives (#if swift(...)) across several test files and utility sources, including InstallationsAPITests.swift, AsyncAwaitIntegrationTests.swift, DatabaseTests.swift, and HashCalculator.swift. This simplifies the codebase by assuming a modern Swift environment (Swift 5.5+). There are no review comments, and I have no feedback to provide.
Recommend hiding whitespace: https://github.com/firebase/firebase-ios-sdk/pull/16305/changes?w=1
Since the minimum supported Swift version across the SDK has been bumped to 5.9,
#if swift(>=5.x)checks and their corresponding#elseblocks evaluate to true by default and are no longer necessary. This commit removes the redundant directives.#no-changelog