Skip to content

refactor: clean up legacy Swift 5.x version checks#16305

Open
ncooke3 wants to merge 1 commit into
mainfrom
nc.refactor.swift
Open

refactor: clean up legacy Swift 5.x version checks#16305
ncooke3 wants to merge 1 commit into
mainfrom
nc.refactor.swift

Conversation

@ncooke3

@ncooke3 ncooke3 commented Jun 22, 2026

Copy link
Copy Markdown
Member

Recommend hiding whitespace: https://github.com/firebase/firebase-ios-sdk/pull/16305/changes?w=1

Since the minimum supported Swift version across the SDK has been bumped to 5.9, #if swift(>=5.x) checks and their corresponding #else blocks evaluate to true by default and are no longer necessary. This commit removes the redundant directives.

#no-changelog

Since the minimum supported Swift version across the SDK has been bumped to 5.9, `#if swift(>=5.x)` checks and their corresponding `#else` blocks evaluate to true by default and are no longer necessary. This commit removes these redundant directives to clean up the codebase.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@ncooke3

ncooke3 commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes obsolete Swift version check compiler directives (#if swift(...)) across several test files and utility sources, including InstallationsAPITests.swift, AsyncAwaitIntegrationTests.swift, DatabaseTests.swift, and HashCalculator.swift. This simplifies the codebase by assuming a modern Swift environment (Swift 5.5+). There are no review comments, and I have no feedback to provide.

@ncooke3 ncooke3 marked this pull request as ready for review June 22, 2026 18:55
@ncooke3 ncooke3 requested a review from a team as a code owner June 22, 2026 18:55
@ncooke3 ncooke3 requested review from andrewheard and paulb777 June 22, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant