fix(ailogic): xcode 27 renaming deprecation

[ncooke3]

Param name for sampling is slightly different. Old: sampling New: samplingMode

- sampling:
+ samplingMode:

https://github.com/firebase/firebase-ios-sdk/pull/16297/changes?w=1

#no-changelog

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

[ncooke3]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces conditional compilation (#if compiler(>=6.4)) in GenerationOptions.swift to handle API differences in FoundationModels.GenerationOptions (specifically the transition from sampling to samplingMode). The review feedback suggests a cleaner, more idiomatic Swift approach by directly instantiating the options within each conditional branch instead of dynamically referencing the initializer via a local variable.

[paulb777]

Looks the same?

[ncooke3]

Param name for sampling is slightly different. Old: sampling New: samplingMode

diff --git a/FirebaseAI/Sources/Types/Public/GenerationOptions.swift b/FirebaseAI/Sources/Types/Public/GenerationOptions.swift
index 99c62360ac3..2f7db8d16a3 100644
--- a/FirebaseAI/Sources/Types/Public/GenerationOptions.swift
+++ b/FirebaseAI/Sources/Types/Public/GenerationOptions.swift
@@ -171,11 +178,20 @@
             return generationOptions
           }
 
-          return FoundationModels.GenerationOptions(
-            sampling: sampling?.samplingMode,
+            return FoundationModels.GenerationOptions(
+              samplingMode: sampling?.samplingMode,
+            return FoundationModels.GenerationOptions(
+              sampling: sampling?.samplingMode,
 

[paulb777]

I see it now. Thanks!

[andrewheard]

Could we match the formatting in main...wwdc26-preview#diff-3232ba7f8f to avoid merge conflicts?

[ncooke3]

Could we match the formatting in main...wwdc26-preview#diff-3232ba7f8f to avoid merge conflicts?

My bad, didn't realize it was already fixed in there. Will the merge to main be coming soon-ish? If so, I'll just close this PR.

[andrewheard]

Could we match the formatting in main...wwdc26-preview#diff-3232ba7f8f to avoid merge conflicts?

My bad, didn't realize it was already fixed in there. Will the merge to main be coming soon-ish? If so, I'll just close this PR.

@ncooke3 Np. Let's discuss offline. I'm not a fan of long-lived feature branches but we can't really merge to main (without additional steps) until the Xcode 27 RC in September since the Foundation Models APIs could have breaking changes before then.

Some options are an XcodeBeta trait that we use for pre-release features or a define in SwiftSettings and we enable it in the wwdc26-preview branch. Although they are an option, I think environment variables are too painful to use with Xcode so I'd like to avoid them.