Skip to content

test: Increase timeout in testListenForChildChangedWithLimitEnsureEventsFireProperly#16279

Open
paulb777 wants to merge 2 commits into
mainfrom
pb-database-test-flake-fix
Open

test: Increase timeout in testListenForChildChangedWithLimitEnsureEventsFireProperly#16279
paulb777 wants to merge 2 commits into
mainfrom
pb-database-test-flake-fix

Conversation

@paulb777

@paulb777 paulb777 commented Jun 13, 2026

Copy link
Copy Markdown
Member

Addresses CI database integration test timeout flakiness by increasing the event waiting timeout from 10 seconds to 30 seconds.

This test that failed in multiple runs of #16278 now passes.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@danger-firebase-ios

Copy link
Copy Markdown
1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the use of the WAIT_FOR macro with explicit waitUntil:timeout: block-based assertions in FIRDatabaseQueryTests.m to handle asynchronous waiting with a 30-second timeout. There are no review comments to address, and I have no feedback to provide.

@paulb777 paulb777 requested a review from ncooke3 June 13, 2026 18:33
@paulb777 paulb777 enabled auto-merge (squash) June 13, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant