fix(auth): handle external sign-in callbacks when using scene delegates in sample app#16261
fix(auth): handle external sign-in callbacks when using scene delegates in sample app#16261daymxn wants to merge 1 commit into
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
ncooke3
left a comment
There was a problem hiding this comment.
Would any changes need to be made for customers? Like docs updates?
|
Also, there are some CI fixes to look into. |
Per b/522347894,
This fixes the issue within one of the Firebase Auth sample apps, where usage of scene delegates would break the external sign-in flow.
More specifically, within the
AuthenticationExamplesample app that auth has, the handling of Google sign-in/Facebook sign-in is properly done for the App delegate path. But the scene delegate path does not call either of these methods.When an app is using scene delegates, certain app delegate methods won't be called. In this case, it's the
application:openURL:options:method. The scene delegate already has a correspondingscene:openURLContexts:, but it needs to be updated to call the external sign-in callbacks.This PR adds those callbacks to the scene delegate.
#no-changelog