Skip to content

fix(auth): handle external sign-in callbacks when using scene delegates in sample app#16261

Open
daymxn wants to merge 1 commit into
mainfrom
dlr/update-auth-sample-scenes
Open

fix(auth): handle external sign-in callbacks when using scene delegates in sample app#16261
daymxn wants to merge 1 commit into
mainfrom
dlr/update-auth-sample-scenes

Conversation

@daymxn

@daymxn daymxn commented Jun 10, 2026

Copy link
Copy Markdown
Member

Per b/522347894,

This fixes the issue within one of the Firebase Auth sample apps, where usage of scene delegates would break the external sign-in flow.

More specifically, within the AuthenticationExample sample app that auth has, the handling of Google sign-in/Facebook sign-in is properly done for the App delegate path. But the scene delegate path does not call either of these methods.

When an app is using scene delegates, certain app delegate methods won't be called. In this case, it's the application:openURL:options: method. The scene delegate already has a corresponding scene:openURLContexts:, but it needs to be updated to call the external sign-in callbacks.

This PR adds those callbacks to the scene delegate.

#no-changelog

@daymxn daymxn added this to the Firebase 13 milestone Jun 10, 2026
@daymxn daymxn requested a review from ncooke3 June 10, 2026 19:00
@daymxn daymxn self-assigned this Jun 10, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@ncooke3 ncooke3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would any changes need to be made for customers? Like docs updates?

@ncooke3

ncooke3 commented Jun 12, 2026

Copy link
Copy Markdown
Member

Also, there are some CI fixes to look into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants