Skip to content

feat: add webhook test endpoint#97

Merged
tlarrain merged 2 commits into
masterfrom
onb-1841-agregar-cambios-en-sdk-de-node
May 15, 2026
Merged

feat: add webhook test endpoint#97
tlarrain merged 2 commits into
masterfrom
onb-1841-agregar-cambios-en-sdk-de-node

Conversation

@tlarrain
Copy link
Copy Markdown
Contributor

Description

Adds support for upcoming endpoint to send test webhook events.

Requirements

Public API needs to be deployed to prod for this to work, still in review.

None.

Additional changes

None.

@tlarrain tlarrain requested a review from FranciscaOtero May 15, 2026 16:59
Copy link
Copy Markdown
Contributor

@FranciscaOtero FranciscaOtero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en general lo veo bien, dejé unas dudas

static methods = ['list', 'get', 'create', 'update', 'delete'];
static methods = ['list', 'get', 'create', 'update', 'delete', 'test'];

@canRaiseHTTPError
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ para que sirve esto?

static methods = ['list', 'get', 'create', 'update', 'delete', 'test'];

@canRaiseHTTPError
async test(webhookEndpointId: string, args: { type: string }): Promise<WebhookEvent> {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ porque async?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahí actualicé ambas cosas para seguir el patrón del código más al pie de la letra!

@tlarrain tlarrain merged commit f664bb5 into master May 15, 2026
2 checks passed
@tlarrain tlarrain deleted the onb-1841-agregar-cambios-en-sdk-de-node branch May 15, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants