Skip to content

Completed all the remaining Morphir.SDK.Decimal functions#610

Open
nardnana28 wants to merge 11 commits into
finos:mainfrom
nardnana28:patch-7
Open

Completed all the remaining Morphir.SDK.Decimal functions#610
nardnana28 wants to merge 11 commits into
finos:mainfrom
nardnana28:patch-7

Conversation

@nardnana28

Copy link
Copy Markdown

The functions are

hundred
thousand
million
tenth
hundredth
thousandth
millionth

Comment thread morphir/src/org/finos/morphir/runtime/sdk/DecimalSDK.scala Outdated
Comment thread morphir/runtime/test/jvm/src/org/finos/morphir/runtime/EvaluatorMDMTests.scala Outdated
Comment thread morphir/runtime/test/jvm/src/org/finos/morphir/runtime/EvaluatorMDMTests.scala Outdated
val million = DynamicNativeFunction1("million") {
(_: NativeContext) =>
(int: RT.Primitive.Int) =>
val result = int.value.toBigDecimal * 10000

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 val result = int.value.toBigDecimal * 1_000_000

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks for the review

@DamianReeves

Copy link
Copy Markdown
Member

You need to format this commit.

@bensanchin

Copy link
Copy Markdown
Contributor

@nardnana28 The below command should take care of the formatting:

./build.sh lint

@michelchan

Copy link
Copy Markdown
Contributor

do we still want this? if not, ill be closing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants