Completed all the remaining Morphir.SDK.Decimal functions#610
Open
nardnana28 wants to merge 11 commits into
Open
Completed all the remaining Morphir.SDK.Decimal functions#610nardnana28 wants to merge 11 commits into
nardnana28 wants to merge 11 commits into
Conversation
bensanchin
suggested changes
May 9, 2024
| val million = DynamicNativeFunction1("million") { | ||
| (_: NativeContext) => | ||
| (int: RT.Primitive.Int) => | ||
| val result = int.value.toBigDecimal * 10000 |
Contributor
There was a problem hiding this comment.
val result = int.value.toBigDecimal * 1_000_000
Author
There was a problem hiding this comment.
Fixed, thanks for the review
Member
|
You need to format this commit. |
Contributor
|
@nardnana28 The below command should take care of the formatting: |
Contributor
|
do we still want this? if not, ill be closing it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functions are
hundred
thousand
million
tenth
hundredth
thousandth
millionth