-
Notifications
You must be signed in to change notification settings - Fork 69
feat(mise): add setup:npm task so mise run default works from fresh clone #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3832cee
feat(mise): add setup:npm task to run npm ci
DamianReeves 6f08aa4
feat(mise): make setup:elm-tooling depend on setup:npm
DamianReeves 37f272f
feat(mise): include setup:npm in setup aggregate task
DamianReeves 4a560a9
docs: replace manual npm ci with mise run setup in Quick Start
DamianReeves 973e9c5
fix(ci): remove redundant npm ci step — mise run default handles it
DamianReeves cc3e39f
fix(mise): build must depend on setup to prevent elm-not-found race
DamianReeves 4869003
fix(mise): build:check-elm-docs must wait for setup:elm-tooling
DamianReeves 4a8fc63
fix(mise): sequence setup before build in default without polluting t…
DamianReeves 98d37fb
chore(deps): bump elm-tooling to 1.17 and elm-format to 0.8.8
DamianReeves dfe1130
fix(mise): serialize elm builds to prevent ~/.elm cache race on Windows
DamianReeves 7289dac
fix(mise): build:morphir-ts must wait for build:cli2 (needs Morphir.E…
DamianReeves File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,10 @@ | ||
| #!/usr/bin/env bun | ||
| //MISE description="Full build pipeline (clean, check, setup, build)" | ||
| //MISE depends=["clean", "test:check-package-lock", "test:check-node-version", "setup", "build"] | ||
| //MISE depends=["clean", "test:check-package-lock", "test:check-node-version", "setup"] | ||
|
|
||
| import { log } from "./_lib.ts"; | ||
| import { exec, log, ROOT_DIR } from "./_lib.ts"; | ||
|
|
||
| // setup has completed — now run build phase (elm requires node_modules from setup) | ||
| await exec("mise", ["run", "build"], { cwd: ROOT_DIR }); | ||
|
|
||
| log("default", "Full build pipeline completed"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| #!/usr/bin/env bun | ||
| //MISE description="Install npm dependencies (npm ci)" | ||
|
|
||
| import { exec, log } from "../_lib.ts"; | ||
|
|
||
| log("setup:npm", "Installing npm dependencies..."); | ||
| await exec("npm", ["ci"]); | ||
| log("setup:npm", "Done"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
setup:npmonly under thesetupaggregate does not make thebuildbranch ofmise run defaultwait for npm dependencies:default.tsstill depends onsetupandbuildas independent siblings, andmise run --dry-run defaultprintsbuild:check-elm-docsbeforesetup:npm. On a fresh clone or in the updated CI workflow where the explicitnpm cistep was removed, the build can invokeelm/npxbeforenode_modules/.binexists, so the default pipeline can still fail instead of becoming self-bootstrapping.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 4869003 — added
//MISE depends=["setup:elm-tooling"]tobuild:check-elm-docs.ts. All other elm build tasks already chain throughbuild:check-elm-docs, so this single dep propagates the ordering constraint through the full build chain. Also addedbuild:build.ts depends=[setup,...]as an explicit guard, and removed the standalonenpm ciCI step that was masking the race.