Use fixed 89-day window for run_checks#231
Merged
Merged
Conversation
The start time for `searchEvents` was calculated using a **3-month interval** (`P3M`), which is calendar-based and can resolve to 80+ days depending on which months are involved. The Fingerprint API rejects start times older than 90 days, causing the `run_checks.php` script to fail when 3 calendar months exceeded that threshold. Replaced `P3M` with `P89D` to use a fixed 89-day window that always stays within the API limit.
Contributor
pnpm exec changesetto create a changeset. |
There was a problem hiding this comment.
Pull request overview
Updates the run_checks.php script to use a fixed-day lookback window when calling searchEvents, ensuring the computed start time consistently stays within the Fingerprint API’s 90-day limit (avoiding calendar-month variability from P3M).
Changes:
- Replace the calendar-based
DateInterval('P3M')with a fixedDateInterval('P89D')for thesearchEventsstart time.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
🟢 Coverage increased by 83.98% Code Coverage ReportCoverage Report
Files Coverage
|
erayaydin
requested review from
Orkuncakilkaya,
TheUnderScorer and
ilfa
as code owners
Orkuncakilkaya
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
run_checks.phpcalculated thesearchEventsstart time using a 3-month (P3M) interval. Because PHP'sDateIntervalwith months is calendar-based, this can resolve to 89+ days depending on which months are spanned/included.The Fingerprint API rejects start times older than 90 days, so the check script would fail.
Fix
Replace
P3MwithP89Dto use a fixed 89-day window, which always stays within the API limit regardless of the calendar month.