<1> Improved Exception Handling <2> Readme updates <3> Fix type error on write file <4> Depr. has_key updated with has_attr#1
Open
LukasWillin wants to merge 10 commits into
Open
Conversation
… exception 1. TypeError: write() argument must be str, not bytes Thrown because of encoding on Windows with python 3.8.x 2. Write exception to console instead of writing your own
<1> Fix TypeError when writing html to outputfile <2> Output original exception
<1:#2> Replace has_key with has_attr
Output exception when file.read() fails to help with debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hmm I thought I had created a PR for this. But apparently I have not yet.
Anyways here are the changes I have made so far to get it running again (Windows Environment) as well as some minor improvements.
This PR:
has_keywithhas_attr