fix(downsampler): replace Kamon.stopModules() with Thread.sleep to av…#2283
Merged
Conversation
…oid double shutdown (filodb#2281) KamonShutdownHook.registerShutdownHook() is already registered, so calling Kamon.stopModules() a second time caused a conflict. Use Thread.sleep instead to preserve the metrics flush delay. Co-authored-by: Yu Zhang <yzhang999272@apple.com>
alextheimer
previously approved these changes
Jun 9, 2026
alextheimer
reviewed
Jun 9, 2026
alextheimer
left a comment
alextheimer
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but make sure you bump the version
alextheimer
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oid double shutdown (#2281)
KamonShutdownHook.registerShutdownHook() is already registered, so calling Kamon.stopModules() a second time caused a conflict. Use Thread.sleep instead to preserve the metrics flush delay.
Pull Request checklist
Current behavior : (link exiting issues here : https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)
New behavior :
BREAKING CHANGES
If this PR contains a breaking change, please describe the impact and migration
path for existing applications.
If not please remove this section.
Breaking changes may include:
Other information: