Skip to content

chore: Give StorSwift-members push access to Lotus - #206

Merged
rjan90 merged 2 commits into
filecoin-project:masterfrom
rjan90:phi/add-storswift-lotus
May 18, 2026
Merged

chore: Give StorSwift-members push access to Lotus#206
rjan90 merged 2 commits into
filecoin-project:masterfrom
rjan90:phi/add-storswift-lotus

Conversation

@rjan90

@rjan90 rjan90 commented May 18, 2026

Copy link
Copy Markdown
Contributor

Why do you need this?

StorSwift maintains Lotus-Miner

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@rjan90
rjan90 requested a review from a team as a code owner May 18, 2026 07:52
@github-actions

Copy link
Copy Markdown
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
User marco-storswift:
  - will gain push permission to lotus
User snail8501:
  - will gain push permission to lotus

@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Before merge, verify that all the following plans are correct. After merge, Apply will regenerate the plans from the merged commit and continue only if they match.

Terraform plans

filecoin-project
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # github_team_membership.this["lotus-miner-maintainers:marco-storswift"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "12314353"
      + username = "marco-storswift"
    }

  # github_team_membership.this["lotus-miner-maintainers:snail8501"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "12314353"
      + username = "snail8501"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

@rjan90
rjan90 requested a review from BigLep May 18, 2026 09:02

@rvagg rvagg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok but this would be better if you just made a team for them and put their access into the teams section, that would make it more manageable going forward

@rjan90

rjan90 commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

We already have a lotus-miner maintenance team in here, so I moved them over there.

@rjan90
rjan90 merged commit fdb9835 into filecoin-project:master May 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants