Create ff-design team, give them push access to hyperspace

[ianconsolata]

Summary

Create ff-design team, give them push access to hyperspace

Why do you need this?

Design wants to work directly on frontend components in the repo, and we have branch protections setup to prevent them from merging directly to production without code review so there is no harm in giving them push access to create their own branches and PRs.

DRI: myself

Reviewer's Checklist

• It is clear where the request is coming from (if unsure, ask)
• All the automated checks passed
• The YAML changes reflect the summary of the request
• The Terraform plan posted as a comment reflects the summary of the request

[github-actions]

The following access changes will be introduced as a result of applying the plan:

Access Changes

User pwrepo:
  - will lose admin permission to filhyperspace

[BigLep]

Suggested change

	- pwrepo
	- lanzafame
	- pwrepo
	has_discussions: false
	merge_commit_message: PR_TITLE
	merge_commit_title: MERGE_MESSAGE
	secret_scanning_push_protection: false
	secret_scanning: false
	squash_merge_commit_message: COMMIT_MESSAGES
	squash_merge_commit_title: COMMIT_OR_PR_TITLE
	teams:
	admin:
	- ff-eng
	push:
	- ff-design

[BigLep]

pwreop is a collaborator, not a team

[BigLep]

Hi Ian - I know you're adjusting permissions through github-mgmt. Feel free to do it directly in your repo too if that's easier for you. github mgmt will sync. I find github-mgmt great for resources that are more shared and mission critical for the ecosystem and want to give visibility or get checks on the changes.
Do as you wish, just wanted to make sure you feel freedom to not use github-mgmt for your team's repos.

[galargh]

FYI, unfortunately, team creation + assignment have to be split across 2 PRs. That's because we don't know the ID of a team until it actually exists and the current implementation needs it to handle team-repo assignments.

[ianconsolata]

Sounds great! I can edit this PR to only do team creation (which I don't think I can do on my own), and then I will manually make the other changes in our repo directly. Good to know I don't need to go through this repo for internal repo changes

[github-actions]

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

filecoin-project

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # github_team.this["ff-design"] will be created
  + resource "github_team" "this" {
      + create_default_maintainer = false
      + etag                      = (known after apply)
      + id                        = (known after apply)
      + members_count             = (known after apply)
      + name                      = "ff-design"
      + node_id                   = (known after apply)
      + parent_team_read_id       = (known after apply)
      + parent_team_read_slug     = (known after apply)
      + privacy                   = "secret"
      + slug                      = (known after apply)
    }

  # github_team_membership.this["ff-design:filecoinfoundation-inf"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "filecoinfoundation-inf"
    }

  # github_team_membership.this["ff-design:filipagr"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = (known after apply)
      + username = "filipagr"
    }

  # github_team_membership.this["ff-design:gmoranxyz"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = (known after apply)
      + username = "gmoranxyz"
    }

  # github_team_membership.this["ff-design:ianconsolata"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "ianconsolata"
    }

  # github_team_membership.this["ff-eng:pwrepo"] will be destroyed
  # (because key ["ff-eng:pwrepo"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"0733cea500be0fa5763d728e1a68d19d28b06d0cc96a2c527cfdee27e788fa0f\"" -> null
      - id       = "16228647:pwrepo" -> null
      - role     = "member" -> null
      - team_id  = "16228647" -> null
      - username = "pwrepo" -> null
    }

Plan: 5 to add, 0 to change, 1 to destroy.