Issue #2759 - Domain-driven testing: prevent entity ID conflicts#2764
Open
homedirectory wants to merge 18 commits into
Open
Issue #2759 - Domain-driven testing: prevent entity ID conflicts#2764homedirectory wants to merge 18 commits into
homedirectory wants to merge 18 commits into
Conversation
Applications no longer override setDbCreator. They implement two abstract methods from AbstractDomainDrivenTestCase: - prePopulateDomain — call every @EnsureData method. - afterPrePopulation — release per-JVM cleanup state. The orchestration (PRE_POPULATED, seed capture, seed-script persistence, truncation) now lives in DbCreator.runPrePopulation.
…ached Mode
This is to prevent outdated scripts from being used for test data population.
In the common case, a new pre-population scripts will overwrite the old one.
But it could also be the case that a pre-population method has mistakenly not been listed in the
pre-population procedure (`prePopulateDomain()`), which will later lead to a Cached Mode test run
with `loadDataScriptFromFile = true` to load the stale script.
This commit also changes the naming convention for pre-population scripts: prePopulate-${methodName}.script.
This is to be able to easily identify them.
The previous convention was ${methodName}.script, which required either
knowing all the @EnsureData method names or deleting all files in the
directory except those that are not pre-population scripts.
This requires changing EnsureDataInterceptor to use the new naming convention.
With this change, application-level AbstractDaoTestCase.populateDomain no longer has to call resetIdGenerator().
…the base test class
homedirectory
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #2759
To be completed by the pull request creator
This section should be completed with reference to section Preparing PR of the Code and PR reviews wiki page.
Create the pull request as a draft by tapping the dropdown arrow on the 'Create pull request' button under the pull request description (below the text box where this description is being edited) and changing the default
Create pull requesttoDraft pull request.Or, if the pull request has already been created, convert it to draft by tapping the "Convert to draft" link beneath the "Reviewers" section.
A self-review of all changes has been completed, and the changes are in sync with the issue requirements.
Changes to the requirements have been reflected in the issue description.
Any "leftovers" such as sysouts, printing of stack traces, and any other "temporary" code, have been removed.
Minor refactorings, such as renamings, extraction of constants, etc., have been addressed.
Developer documentation (e.g., comments, Javadoc), have been provided where required.
All existing and new Web tests pass successfully.
Changes have been inspected for possible NPE situations, and the changes are sufficiently defensive.
The correct base branch has been selected for these changes to be merged into.
The latest changes from the base branch have already been merged into this feature branch (and tested).
Added a change overview to the issue description or as a wiki page, referenced in the issue description.
Some issues might be very descriptive and serve in place of a wiki page.
In such cases consider adding label
Wiki liketo the issue.Changes subject to performance considerations have been evaluated, and tested against production-size data if applicable.
This pull request does contain significant changes, the section "Significant changes" below is completed and at least one Senior Software Engineer with the relevant area of expertise has been selected as reviewer.
The
In progresslabel has been removed from the issue.The
Pull requestlabel has been added to the issue.The pull request has been made ready for review by tapping the "Ready for review" button below the list of commits on the pull request page.
Significant changes
This pull request contains significant changes as defined in the wiki page.
Details are as follows:
This PR contains a significant refactoring of the domain-driven testing framework.
The main effort went into preventing entity ID conflicts, which is described in detail in a wiki page.
tglib-testinghad to be modified -- see tglib-testing/12.ports/437 can be used as a reference application incorporating these changes.
To be completed by the pull request reviewer
This section should be completed with reference to section Performing PR review of the Code and PR reviews wiki page.
The
In progresslabel has been added to the pull request in GitHub.The issue requirements have been read and understood (along with any relevant emails and/or Slack messages).
The correct base branch is specified, and that base branch is up-to-date in the local source.
The issue branch has been checked out locally, and had the base branch merged into it.
All automated tests pass successfully.
Ensure the implementation satisfies the functional requirements.
Ensure that code changes are secure and align with the established coding practices, including code formatting and naming conventions.
Ensure that code changes are documented and covered with automated tests as applicable.
Ensure that code changes are well-suited for informal reasoning.
Ensure that changes are documented for the end-user (a software engineer in the case of TG, or an application user in the case of TG-based applications).
If there are significant changes (described above), special attention has been paid to them.
Marked the task items in section "Significant changes" as completed to indicate that corresponding changes have been reviewed, improved if necessary, and approved.
The issue or issues addressed by the pull request are associated with the relevant release milestone.
To be completed by the pull request reviewer once the changes have been reviewed and accepted
The changes have been merged into the base branch (unless there is a specific request not to do so, e.g., they are to be released to SIT).
The issue branch has been deleted (unless the changes have not been merged - see above, or there is a specific request not to do so).
The
In progresslabel has been removed from the pull request.The
Pull requestlabel has been removed from the issue.