Issue #2716 - Independent time-zone mode: opt-out properties#2723
Closed
jhou-pro wants to merge 117 commits into
Closed
Issue #2716 - Independent time-zone mode: opt-out properties#2723jhou-pro wants to merge 117 commits into
jhou-pro wants to merge 117 commits into
Conversation
…ion for API running of the centre. Fresh version may contain user modifications, which must be left as is; but should not be taken into account for API running.
Such alteration will affect UI configurations, which should be avoided. P.S. Generator-like centres will still affect result-sets. This is considered acceptable. But should be revised / tested later.
…es taken from upstream. 'updateFromUpstream' has side effects and these side effects are required.
These are only a placeholders for some parameterised Entity Centre links. We only care about saved named configurations of concrete users.
a. Reduce API - 1) only for owner; 2) no special hyperlinks. b. Always run fresh configuration, i.e. configuration with unsaved changes.
…omplexity. * Reuse utility functions as much as possible. * Reduce implementation complexity by separating EQL model code from actual querying. * Minor simplifications around fetching.
…ning of mobile configurations exactly as desktop ones.
The impact includes sending of invalid criteria entity wrapped into unsuccessful validation result instead of 'Result.successful'. This is now exactly like for authorisation results or invalid IGenerator results.
The test resides in -web-resources module to take into account UI configurations (DSL) being executed by the API. Additional API extension is possible (through ICentreDomainTreeManagerAndEnhancer) to provide ability to define custom values for criteria, sorting and other Entity Centre settings in unit tests. The same approach is possible in end applications for unit tests in -web-server module (see WebUiConfigTest for more).
…tre configurations to make EntityCentreAPITest happy.
Web test becomes broken though.
centre/test/tg-entity-centre.html
entity centre
running does not occur for invalid criteria
…s as not needed. Adjust web test.
… running in case of API.
Date values convert to String representation. See end-application Lead Time Analysis reports, where horizontal axis has date values.
… for regular, fixed tz and DependentTimeZoneMode properties.
…only if not specified explicitly. Minor improvements.
* Abstract out more high-level API and hide internal API in date utils. Adjust external imports accordingly. * Reduce code duplication. * Correct / strengthen optional chaining to check intended properties. * Improve 'now' API to be simpler and in sync with other APIs (+test).
…on. It is now taken from entity type property on the client. * Extract String constants. * Jdocs markdownisation. * Static imports. * Code reuse. * Code formatting for easier reading.
…tres. See more modern approach in #2407, see section 'Change overview'.
…ityCentreProcessor.validate' API. This may be useful for the API clients, e.g. if foreign key reference is mandatory on the config instance being executed.
jhou-pro
changed the title
# Conflicts: # platform-pojo-bl/src/main/java/ua/com/fielden/platform/criteria/generator/impl/CriteriaGenerator.java
Member
Author
|
Superceded by #2756. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #2716
To be completed by the pull request creator
This section should be completed with reference to section Preparing PR of the Code and PR reviews wiki page.
Create the pull request as a draft by tapping the dropdown arrow on the 'Create pull request' button under the pull request description (below the text box where this description is being edited) and changing the default
Create pull requesttoDraft pull request.Or, if the pull request has already been created, convert it to draft by tapping the "Convert to draft" link beneath the "Reviewers" section.
A self-review of all changes has been completed, and the changes are in sync with the issue requirements.
Changes to the requirements have been reflected in the issue description.
Any "leftovers" such as sysouts, printing of stack traces, and any other "temporary" code, have been removed.
Minor refactorings, such as renamings, extraction of constants, etc., have been addressed.
Developer documentation (e.g., comments, Javadoc), have been provided where required.
All existing and new Java tests pass successfully by running them with Maven.
New Web tests have been written or existing tests adjusted, if required, to cover the new functionality.
All existing and new Web tests pass successfully.
Changes have been inspected for possible NPE situations, and the changes are sufficiently defensive.
The correct base branch has been selected for these changes to be merged into.
The latest changes from the base branch have already been merged into this feature branch (and tested).
Added a change overview to the issue description or as a wiki page, referenced in the issue description.
Some issues might be very descriptive and serve in place of a wiki page.
In such cases consider adding label
Wiki liketo the issue.Changes subject to performance considerations have been evaluated, and tested against production-size data if applicable.
This pull request does not contain significant changes, and at least one appropriate reviewer has been selected.
The
In progresslabel has been removed from the issue.The
Pull requestlabel has been added to the issue.The pull request has been made ready for review by tapping the "Ready for review" button below the list of commits on the pull request page.
To be completed by the pull request reviewer
This section should be completed with reference to section Performing PR review of the Code and PR reviews wiki page.
The
In progresslabel has been added to the pull request in GitHub.The issue requirements have been read and understood (along with any relevant emails and/or Slack messages).
The correct base branch is specified, and that base branch is up-to-date in the local source.
The issue branch has been checked out locally, and had the base branch merged into it.
All automated tests pass successfully.
Ensure the implementation satisfies the functional requirements.
Ensure that code changes are secure and align with the established coding practices, including code formatting and naming conventions.
Ensure that code changes are documented and covered with automated tests as applicable.
Ensure that code changes are well-suited for informal reasoning.
Ensure that changes are documented for the end-user (a software engineer in the case of TG, or an application user in the case of TG-based applications).
If there are significant changes (described above), special attention has been paid to them.
Marked the task items in section "Significant changes" as completed to indicate that corresponding changes have been reviewed, improved if necessary, and approved.
The issue or issues addressed by the pull request are associated with the relevant release milestone.
To be completed by the pull request reviewer once the changes have been reviewed and accepted
The changes have been merged into the base branch (unless there is a specific request not to do so, e.g., they are to be released to SIT).
The issue branch has been deleted (unless the changes have not been merged - see above, or there is a specific request not to do so).
The
In progresslabel has been removed from the pull request.The
Pull requestlabel has been removed from the issue.