Skip to content

feat: add design tensile strengths for EC2 2004 and MC2010#350

Merged
mortenengen merged 5 commits into
devfrom
design-tensile-strength
May 15, 2026
Merged

feat: add design tensile strengths for EC2 2004 and MC2010#350
mortenengen merged 5 commits into
devfrom
design-tensile-strength

Conversation

@mortenengen

Copy link
Copy Markdown
Member

No description provided.

@mortenengen mortenengen added the enhancement New feature or request label Apr 21, 2026
@mortenengen mortenengen moved this to Under review 👀 in PR tracker Apr 21, 2026
@mortenengen mortenengen marked this pull request as ready for review April 21, 2026 14:04

@talledodiego talledodiego left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect for me.
Just a couple of very minor comments for you to consider

Comment thread structuralcodes/codes/ec2_2004/_concrete_material_properties.py
Comment thread tests/test_ec2_2004/test_ec2_2004_concrete_material_properties.py
Comment thread tests/test_mc2010/test_concrete_mc2010.py
Comment thread tests/test_mc2010/test_mc2010_material_properties.py
Comment thread tests/test_ec2_2004/test_concrete_ec2_2004.py
@mortenengen

Copy link
Copy Markdown
Member Author

Perfect for me. Just a couple of very minor comments for you to consider

Thanks for the comments. I added more tests before merging.

@mortenengen mortenengen merged commit c75c019 into dev May 15, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Under review 👀 to Done 🚀 in PR tracker May 15, 2026
@mortenengen mortenengen deleted the design-tensile-strength branch May 15, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done 🚀

Development

Successfully merging this pull request may close these issues.

2 participants