Added corrosion functions#302
Closed
AndreaEste97 wants to merge 5 commits into
Closed
Conversation
github-project-automation
Bot
moved this from Needs review 📣
to Under review 👀
in PR tracker
Author
|
The following changes have been applied:
|
Collaborator
|
I am closing this and moving to #356 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following has been added:
two functions (calculate_velocity_of_corrosion and calculate_minimum_area_after_corrosion), which implements many formula of ModelCode2020 (chapter 30.1). These functions are located in a new file, corrosion.py, which is placed in a new folder (structuralcodes.development), along with a blank init.py file.
an example code usage_corrosion, which is located near the other example codes in docs._example_code.
many of these two functions, which are placed in a new file, test_corrosion.py, which is located in a new folder, test_corrosion, which is located near the other test folders in tests.