Fix MySQL tag filters#68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MySQL backend built a single LIKE pattern that concatenated all values of a tag filter into one ordered string, so an event only matched when it happened to contain every requested value in that exact order. This made multi-value tag filters effectively unsatisfiable and mismatched the semantics of the other backends.
Each tag value now produces its own
tags LIKE ?clause joined with OR, so a tag key matches when the event carries any of the requested values, while distinct tag keys remain ANDed together as independent conditions. A regression test covering single- and multi-value tag queries is included.This mirrors the equivalent MongoDB tag-filter fix.