implement NIP-62#49
Open
mattn wants to merge 5 commits into
Open
Conversation
Owner
|
Looks good, but I didn't review carefully. |
fiatjaf
approved these changes
Nov 21, 2025
- lmdb: stop deleting from the pubkey index while iterating its own cursor, which corrupted iteration and left entries behind; collect matching events first, then delete via the shared delete(). Also skip kind 62 (vanish requests) to match the other backends. - badger: stream deletes through a WriteBatch over a View snapshot so pubkeys with many events don't blow past the per-transaction size cap (Txn too big), same fix as migration 5. - honor ctx cancellation in the badger/lmdb iteration loops. - replace the magic kind 62 with a named kindRequestToVanish constant across all backends. - add a slicestore VanishPubkey test.
Vanishing is irreversible and deletes every event for evt.PubKey, so a forged kind 62 event with a victim's pubkey must not be honored. Check the signature before saving or vanishing, rejecting invalid requests. Also collapse the duplicated relay-tag handling into a single path and add an exported KindRequestToVanish constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review carefully, as data loss may occur due to my bugs.