implement Replacer for sqlite#35
Closed
fiatjaf wants to merge 0 commit into
Closed
Conversation
fiatjaf
force-pushed
the
sqlite-replacer
branch
from
0db3638 to
1f075a3
Compare
isaqueveras
reviewed
Jan 30, 2025
Collaborator
|
Sorry delay. LGTM |
Collaborator
|
Sorry, could you please fix conflict? |
Collaborator
|
This PR is no longer needed because the SQLite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mattn please take a look.
Also let me know what you think of this
Replacerinterface I just conjured. The idea is to prevent weird race conditions when replacing events and possibly make the process clearer for everybody.I'm using it on
khatruand seems to be working well, but maybe there is a better way.I'm also using it on the
RelayWrappernow, should have asked you about it before because now I remember you were using it onrelayer.