fix(oxlint): guard runOxlint against spawn errors (#679)#730
Open
maiolica wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for vite-plugin-checker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hardens
runOxlintagainst spawn failures so a failedoxlintinvocationcan no longer crash the Vite dev server.
runOxlintcallsnode:child_process.execbut doesn't handle:exec()itself, or'error'events emitted on the returnedChildProcess(thesefire before the exit callback runs).
In large pnpm monorepos where oxlint is re-run on every file change, the
spawn can intermittently fail (e.g. resource pressure under a flurry of
changes). The unhandled error currently takes down the whole dev server.
Change
Wrap the
exec()call intry/catchand attach achild.on('error', ...)listener. Both paths resolve to an empty diagnostics array, which the rest
of the checker already treats as a clean run — so a transient spawn failure
is silently swallowed and the next run can succeed.
Notes
Fixes the second issue reported in #679. The first issue in that thread
(
file://URI handling innormalizePath) was already addressed by #714.This mirrors a verified
pnpm patchrunning in production.Closes #679