feat: add support for include and exclude paths in typescript configuration#317
feat: add support for include and exclude paths in typescript configuration#317kumikumi wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 27b38f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for vite-plugin-checker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Based on this PR, do I conclude that this plugin was abandoned? |
|
no, this plugin is not abandoned, as you can see from checking the releases |
|
@danielroe can this PR be merged? Since TS isn't keen on doing it on the tsconfig level: microsoft/TypeScript#40426 (comment) This is my surface-level observation, so it's possible that I reached incorrect conclusions here. |
|
i don't think this would solve that. exclude only prevents files from being included via include - it does not prevent files in node_modules from being checked if they are pulled into the project by being referenced in source files which are in the project |
|
Am I then doing something wrong when Sorry to repost this snippet here, but I can't find my way out of this one. BTW when I do |
|
you probably want to enable |
|
@danielroe Yeah, I'll probably end up adding |
Implements the TypeScript side of #182
Until TypeScript adds support for excluding files or directories from typechecking (see my comment for my use case at microsoft/TypeScript#40426 (comment) ), the best we can do is to filter out the errors in the checker plugins.
I have implemented the "exclude" and "include" options to do just that.
The VueTsc side seems similar to the regular TypeScript checker at a glance, I didn't touch it yet because I'm not using Vue. I might implement it as well if there's interest. I'd need to make a repro for that.