sourceQuestIds を additionalSourceQuestIds にリネームし、questId を常にフェッチ対象に含める#17
Merged
Conversation
複数ソースを設定した際に questId 本体のデータがフェッチされないバグを修正。 aggregator は常に questId を先頭ソースとし、additionalSourceQuestIds を追加ソースとして扱う。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
複数ソース設定時に questId 本体の Harvest データがフェッチ対象から漏れる問題を解消するため、クエストのソース指定フィールドを sourceQuestIds から additionalSourceQuestIds にリネームし、aggregator 側で常に questId を先頭ソースとして扱うようにするPRです。
Changes:
- Quest 型のフィールドを
sourceQuestIds→additionalSourceQuestIdsにリネーム（admin/viewer） - aggregator のソースID決定ロジックを「常に questId + 追加ソース」に変更
- aggregator のテストを新フィールド名・新仕様に合わせて更新
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| viewer/src/types.ts | Quest 型のソース指定フィールド名をリネーム |
| admin/src/types/index.ts | Quest 型のソース指定フィールド名をリネーム |
| admin/src/pages/EventFormPage.tsx | 複数ソース編集UIの参照/更新先を新フィールド名へ変更 |
| lambda/aggregator/handler.py | ソースIDの構築を「questId + additional」に変更 |
| lambda/aggregator/test_handler.py | process_quest のテストを新フィールド名・新仕様に合わせて更新 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
複数ソースを設定した際に questId 本体のデータがフェッチされないバグを修正。
aggregator は常に questId を先頭ソースとし、additionalSourceQuestIds を追加ソースとして扱う。