Skip to content

Feature: add "no free heals" (-nfh) challenge flag#154

Open
HansGR wants to merge 6 commits into
ff6wc:devfrom
HansGR:feature/no-free-heals
Open

Feature: add "no free heals" (-nfh) challenge flag#154
HansGR wants to merge 6 commits into
ff6wc:devfrom
HansGR:feature/no-free-heals

Conversation

@HansGR

@HansGR HansGR commented Jun 4, 2026

Copy link
Copy Markdown

Add a new flag -nfh (--no-free-heals) that removes, adds costs, or limits events that recover the party fully. Modified healing events include:

  • The Narshe bucket may be used only 3 times;
  • Healing springs select a random effect from a list that includes healing HP+MP, HP or MP or status only, or applying a random status effect to the party;
  • When sleeping in free beds (i.e. Sabin's House), the party has a chance to be ambushed during the night;
  • The WoB airship healer costs 3000 GP;
  • The Returners hideout and Figaro Castle inns charge money;
  • The Vector hut may be used once (after defeating the battle);
  • The Phantom Train restaurant offers three options, only the most expensive of which guarantees healing;
  • All inn costs are multiplied by 3x (including money randomly stolen at Vector inn, with limit that you can't sleep there if too poor);
  • all other event free heals are removed

The flag should be compatible with all other Worlds Collide flags. Free heals inside event locations are handled in the event classes (e.g. events/doma_wob.py). Inn prices, beds, and recovery springs are modified via functions in events/free_heals.py.

HansGR added 2 commits June 3, 2026 22:53
Add a new flag -nfh (--no-free-heals) that removes, adds costs, or limits events that recover the party fully. New challenge flag spun off from ruination mode.

The flag should be compatible with all other Worlds Collide flags. Free heals inside event locations are handled in the event classes (e.g. events/doma_wob.py). Inn prices, beds, and recovery springs are modified via functions in events/free_heals.py.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the -nfh (--no-free-heals) flag, which restricts or removes free party heals throughout the game, including inns, recovery springs, free beds, and scripted event heals. To support this, a new event/free_heals.py module is added alongside a custom BedHealCharacter field instruction. The feedback highlights critical compilation and logic issues: the Read class is not imported and is incorrectly referenced as field.Read in event/free_heals.py, and a missing branch instruction in BedHealCharacter causes HP healing to fall through into MP healing, violating the intended mutually exclusive behavior.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread event/free_heals.py Outdated
Comment thread event/free_heals.py Outdated
Comment thread instruction/field/custom.py
Include bugfix (size int-like instruction) for python v3.12+

@wrjones104 wrjones104 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All gemini-code-assist comments are valid and should be addressed

HansGR and others added 3 commits June 13, 2026 10:15
import memory.Read for direct reference

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
use memory.Read directly (instead of indirectly through instruction.field

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Updated docstring to match implemented behavior
@HansGR HansGR requested a review from wrjones104 June 13, 2026 14:23
@HansGR

HansGR commented Jun 13, 2026

Copy link
Copy Markdown
Author

All gemini-code-assist comments are valid and should be addressed

Done. Note that the bed heal docstring was out of date: the desired functionality was implemented correctly: if alive and no status effect, add (max HP)/4 AND (max MP)/4. Docstring is now up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants