Feature: add "no free heals" (-nfh) challenge flag#154
Conversation
Add a new flag -nfh (--no-free-heals) that removes, adds costs, or limits events that recover the party fully. New challenge flag spun off from ruination mode. The flag should be compatible with all other Worlds Collide flags. Free heals inside event locations are handled in the event classes (e.g. events/doma_wob.py). Inn prices, beds, and recovery springs are modified via functions in events/free_heals.py.
There was a problem hiding this comment.
Code Review
This pull request introduces the -nfh (--no-free-heals) flag, which restricts or removes free party heals throughout the game, including inns, recovery springs, free beds, and scripted event heals. To support this, a new event/free_heals.py module is added alongside a custom BedHealCharacter field instruction. The feedback highlights critical compilation and logic issues: the Read class is not imported and is incorrectly referenced as field.Read in event/free_heals.py, and a missing branch instruction in BedHealCharacter causes HP healing to fall through into MP healing, violating the intended mutually exclusive behavior.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Include bugfix (size int-like instruction) for python v3.12+
wrjones104
left a comment
There was a problem hiding this comment.
All gemini-code-assist comments are valid and should be addressed
import memory.Read for direct reference Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
use memory.Read directly (instead of indirectly through instruction.field Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Updated docstring to match implemented behavior
Done. Note that the bed heal docstring was out of date: the desired functionality was implemented correctly: if alive and no status effect, add (max HP)/4 AND (max MP)/4. Docstring is now up to date. |
Add a new flag -nfh (--no-free-heals) that removes, adds costs, or limits events that recover the party fully. Modified healing events include:
The flag should be compatible with all other Worlds Collide flags. Free heals inside event locations are handled in the event classes (e.g. events/doma_wob.py). Inn prices, beds, and recovery springs are modified via functions in events/free_heals.py.