Feature: add shops expensive restorative items flag (-seri)#152
Open
HansGR wants to merge 2 commits into
Open
Conversation
Include simplification feedback from Gemini
There was a problem hiding this comment.
Code Review
This pull request introduces a new command-line flag -seri (--shops-expensive-restorative-items) to increase the base price of restorative items. A review comment identifies a compatibility issue where price randomization overwrites the scaled prices because of the execution order in mod(self). It is recommended to apply price randomization before the expensive scaling modifiers.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
wrjones104
requested changes
Jun 13, 2026
Previous version allowed shop random prices (value or percent) flags to overwrite "expensive" flag values. The intent is to calculate random prices first, then modify the prices by multipliers in "expensive" flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a flag -seri (--shops-expensive-restorative-items) that increases the base price of most restorative items. Basic restoratives are increased by a factor 3x by default; high restoratives (X-Potion, X-Ether) are increased by 2x. Elixirs and Megalixirs are not increased (as these are often sold to generate cash). This is intended to add challenge to the resource management by making what restoratives to purchase more of a decision.
This flag should be compatible with all other shop flags.
If there is interest we could add a scalar on this (e.g. -seri 5 for 5x increase in default cost and 3.33x increase in high restoratives). But that can be left for future work.
Resubmitted 6/4/26 to provide a clean patch to dev branch (1.4.4d).