Skip to content

Feature: add shops expensive restorative items flag (-seri)#152

Open
HansGR wants to merge 2 commits into
ff6wc:devfrom
HansGR:feature/shops-expensive-restorative-items
Open

Feature: add shops expensive restorative items flag (-seri)#152
HansGR wants to merge 2 commits into
ff6wc:devfrom
HansGR:feature/shops-expensive-restorative-items

Conversation

@HansGR

@HansGR HansGR commented Jun 4, 2026

Copy link
Copy Markdown

Adds a flag -seri (--shops-expensive-restorative-items) that increases the base price of most restorative items. Basic restoratives are increased by a factor 3x by default; high restoratives (X-Potion, X-Ether) are increased by 2x. Elixirs and Megalixirs are not increased (as these are often sold to generate cash). This is intended to add challenge to the resource management by making what restoratives to purchase more of a decision.

This flag should be compatible with all other shop flags.

If there is interest we could add a scalar on this (e.g. -seri 5 for 5x increase in default cost and 3.33x increase in high restoratives). But that can be left for future work.

Resubmitted 6/4/26 to provide a clean patch to dev branch (1.4.4d).

Include simplification feedback from Gemini

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new command-line flag -seri (--shops-expensive-restorative-items) to increase the base price of restorative items. A review comment identifies a compatibility issue where price randomization overwrites the scaled prices because of the execution order in mod(self). It is recommended to apply price randomization before the expensive scaling modifiers.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread data/items.py
Comment thread data/items.py
Previous version allowed shop random prices (value or percent) flags to overwrite "expensive" flag values.  The intent is to calculate random prices first, then modify the prices by multipliers in "expensive" flags.
@HansGR HansGR requested a review from wrjones104 June 13, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants