fix(plugin): map Hermes session id to a deterministic ferrosa UUID - #6
Open
kumarabd wants to merge 7 commits into
Open
fix(plugin): map Hermes session id to a deterministic ferrosa UUID#6kumarabd wants to merge 7 commits into
kumarabd wants to merge 7 commits into
Conversation
…sadb#5) Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Closes ferrosadb#5 Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…r UUID Aligns with ferrosa-memory PR #138: non-UUID session_id derivation lives on the server (generic, multi-agent). This adapter only threads the harness session id through prefetch, sync_turn, on_memory_write, and on_session_end, with scope="both" on hybrid_search for cross-session recall. Removes plugin/session.py, client UUIDv5 mapping, and the in-repo unittest suite that tested it. Closes ferrosadb#5 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5.
Summary
Revised per maintainer feedback (compare with ferrosa-memory#138): session-id UUID derivation stays in ferrosa-memory (generic, multi-agent). This PR is now a thin adapter fix only:
session_idonprefetch,sync_turn,on_memory_write, andon_session_end(previouslyprefetchomitted it entirely).prefetch/hybrid_searchuses explicitscope="both"for cross-session recall.plugin/session.pyand client-side UUIDv5 mapping — a second mapping layer would produce different session UUIDs than #138's server derivation.Why
Two bugs in the original plugin:
uuid5(NAMESPACE_URL, "ferrosa-memory:session-id:v1:{raw}").prefetchomittedsession_id→ reads always hit the default session even when writes were session-scoped. This PR fixes that regardless of fmem version.Requirements
main2026-06-29) for per-session isolation on non-UUID ids.Test plan
pre-commit run --all-filespassespython -m compileall -q hooks pluginpassessubstituted configured default for caller-provided session_idfor Hermes trafficprefetchrecall includes session-scoped + global results (scope=both)