fix(slice): guard last_one subtraction on Msb0 tail to avoid overflow#307
Open
SAY-5 wants to merge 1 commit into
Open
fix(slice): guard last_one subtraction on Msb0 tail to avoid overflow#307SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #166.
sp_last_oneforMsb0subtracted from the output index in the tail-element branch before checking whether that element actually held a1. On an all-zero slice the output starts atlen() - 1(0 for a single bit) and the unconditional subtraction underflowedusize, panicking with "attempt to subtract with overflow".Lsb0was unaffected because it starts the counter one higher.The fix moves the subtraction inside the
has_oneguard, matching the existinghead-element andEnclavepaths in the same function.Repro from the issue now returns
Noneinstead of panicking:Added a regression test
issue_166covering all-zero, mixed, and single-bitMsb0slices. Verified it fails before the change and passes after; fulltests/issues.rsandcargo test --lib(142 tests) pass.