Skip to content

Refactor deprecated numpy.core.defchararray methods#676

Merged
ndilalla merged 1 commit into
fermiPy:masterfrom
PreisTo:master
Jun 9, 2026
Merged

Refactor deprecated numpy.core.defchararray methods#676
ndilalla merged 1 commit into
fermiPy:masterfrom
PreisTo:master

Conversation

@PreisTo

@PreisTo PreisTo commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

The defchararray is not recommended since numpy 1.4 and the preferred alias for defchararray is numpy.char.

Refactored the only two occurrences in fermipy - local pytests succeeding without issues

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.16%. Comparing base (63b8808) to head (685a83c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
- Coverage   51.23%   51.16%   -0.07%     
==========================================
  Files         145      145              
  Lines       27437    27436       -1     
==========================================
- Hits        14056    14037      -19     
- Misses      13381    13399      +18     
Flag Coverage Δ
unittests 51.16% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ndilalla ndilalla self-requested a review June 9, 2026 18:02
@ndilalla

ndilalla commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Thanks @PreisTo !

@ndilalla ndilalla merged commit 5594f2c into fermiPy:master Jun 9, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants