Skip to content

Add unit tests for GetGoalsForUser route in GoalController#266

Open
malaikahunain wants to merge 2 commits into
fencer-so:mainfrom
malaikahunain:feature/goal-controller-tests
Open

Add unit tests for GetGoalsForUser route in GoalController#266
malaikahunain wants to merge 2 commits into
fencer-so:mainfrom
malaikahunain:feature/goal-controller-tests

Conversation

@malaikahunain

Copy link
Copy Markdown

Summary
This PR adds unit test coverage for the GetForUser (GetGoalsForUser) route in GoalController, using the xUnit testing framework.

Background
As part of the icon feature work, the Goal model was extended with an optional Icon field, and the backend/frontend were wired together so that icon changes persist via a PUT request. Before landing these changes, test coverage was needed to verify the GetGoalsForUser endpoint behaves correctly.

Changes Made

  • Added a new [Fact] test method GetForUser() in CommBank.Tests/GoalControllerTests.cs
  • The test:
    • Arranges fake goals and users using FakeCollections, FakeGoalsService, and FakeUsersService
    • Calls controller.GetForUser(userId) to fetch goals for a specific user
    • Asserts that the result is not null
    • Asserts that each returned item is assignable from Goal
    • Asserts that each goal's UserId matches the expected user

Testing
All tests pass locally:
Passed! - Failed: 0, Passed: 9, Skipped: 0, Total: 9

Notes
No other files were changed in this PR — only test coverage was added.

@gitguardian

gitguardian Bot commented Jun 30, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials 781690b CommBank-Server/appsettings.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant