Benchmark tests#126
Open
fed135 wants to merge 5 commits into
Open
Conversation
mats852
reviewed
Dec 29, 2022
Comment on lines
+10
to
+11
| cache: { enabled: true, tiers: [{ limit: 6939, ttl: 300000000 }] }, //5% of the dataset assets | ||
| batch: { enabled: true, delay: 5, limit: 20 }, |
Collaborator
There was a problem hiding this comment.
Maybe we could add some context to the delay and ttl values if we set them as a multiplication and/or constant
i.e const fiveMinutesMicroseconds = 5 * 60 * 1000000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A brief overview of this PR
Ticket : #000
Changelist
Breaking changes
Merge Checklist