Added requirement for pandas#14
Conversation
|
I've also added nltk corpora data download to the bootstrap.txt and the readme. Sorry my vi has stripped trailing spaces so there are a few too many line changes. It's lines 46 - 51 in the read me I added. I'm not a python native so if there's a better way to do this then please let me know. |
fcappdev
left a comment
fcappdev
left a comment
There was a problem hiding this comment.
I left some comments regarding the bootstrap script.
|
|
||
| python - <<EOF | ||
| import nltk | ||
| nltk.download('all-corpora') |
There was a problem hiding this comment.
We can add to bootstrap.sh the following lines:
python -m nltk.downloader punkt
python -m nltk.downloader stopwords
python -m nltk.downloader wordnet
rather than downloading the entire corpus. This will also set up the environment in one script rather than having to run separate statements.
| conda install -c anaconda qt=4.8.6 -y | ||
| pip install -r requirements.txt -y No newline at end of file | ||
| pip install -r requirements.txt -y | ||
| python - <<EOF |
There was a problem hiding this comment.
Let's replace this block with:
python -m nltk.downloader punkt
python -m nltk.downloader stopwords
python -m nltk.downloader wordnet| flask | ||
| flask-cors | ||
| matplotlib | ||
| pandas |
There was a problem hiding this comment.
Pandas is included with Anaconda. It should be installed with bash Anaconda3-4.3.0-Linux-x86_64.sh -b.
|
Perhaps, since NumPy and SciPy are also included with Anaconda we should remove those from the requirements.txt, too. At the same time, I can update the MacOS install instructions to also install Anaconda in a virtual env via wget so that the installation instructions will be aligned. |
3 participants
There is a dependency for pandas. Added it to the requirements.txt